Creating user via API give correct responses if the user already exists or the mail address is malformed.

This commit is contained in:
2026-02-18 10:47:37 +01:00
parent 601e08220d
commit 6c41f69723
2 changed files with 58 additions and 5 deletions

View File

@ -12,11 +12,23 @@ defmodule BeetRoundServerWeb.UserController do
end
def create(conn, %{"user" => user_params}) do
with {:ok, %User{} = user} <- Accounts.register_user(user_params) do
conn
|> put_status(:created)
|> put_resp_header("location", ~p"/api/users/#{user}")
|> render(:show, user: user)
case Accounts.register_user(user_params) do
{:ok, %User{} = user} ->
send_created_response(conn, user)
{:error, changeset} ->
with %User{} = user <- Accounts.get_user_by_email(user_params["email"]) do
send_already_reported_response(conn, user)
else
_ ->
send_not_acceptable(conn, changeset)
end
_ ->
conn
|> put_status(:bad_request)
|> put_resp_header("location", ~p"/api/users")
|> render(:show, changeset: "Bad request")
end
end
@ -40,4 +52,24 @@ defmodule BeetRoundServerWeb.UserController do
# send_resp(conn, :no_content, "")
# end
# end
defp send_created_response(conn, %User{} = user) do
conn
|> put_status(:created)
|> put_resp_header("location", ~p"/api/users/#{user}")
|> render(:show, %{user: user})
end
defp send_already_reported_response(conn, %User{} = user) do
conn
|> put_status(:already_reported)
|> render(:show, %{user: user})
end
defp send_not_acceptable(conn, changeset) do
conn
|> put_status(:not_acceptable)
|> put_resp_header("location", ~p"/api/users")
|> render(:show, changeset: changeset)
end
end