Iterating over USER_FACING_ROLES to get all the item values when parsing and keeping them in edit and remove commands. Instead of using each role explicitly.

formats/jsonparser.cpp

@@ -23,6 +23,39 @@ QList<QHash<int, QVariant>> JsonParser::toItemValuesList(const QByteArray& jsonD
   return result;
 }
 
+QByteArray JsonParser::itemValuesListToJson(const QList<QHash<int, QVariant>>& itemValuesList,
+                                            const QString& objectName) {
+  QJsonDocument jsonDoc;
+  QJsonObject rootObject;
+  QJsonArray itemArray;
+  for (const QHash<int, QVariant>& itemValues : itemValuesList) {
+    QJsonObject itemObject;
+
+    QListIterator<UserRoles> i(USER_FACING_ROLES);
+    while (i.hasNext()) {
+      const UserRoles role   = i.next();
+      const QString roleName = ROLE_NAMES.value(role);
+      const QVariant value   = itemValues.value(role);
+      if (STRING_ROLES.contains(role)) {
+        itemObject.insert(roleName, value.toString());
+      } else if (INT_ROLES.contains(role)) {
+        itemObject.insert(roleName, value.toInt());
+      } else if (DOUBLE_ROLES.contains(role)) {
+        itemObject.insert(roleName, value.toDouble());
+      } else {
+        qCritical() << QString("Can't find data type for role %1!!!").arg(role);
+      }
+    }
+
+    itemArray.append(itemObject);
+  }
+
+  rootObject.insert(objectName, itemArray);
+  jsonDoc.setObject(rootObject);
+
+  return jsonDoc.toJson(QJsonDocument::Compact);
+}
+
 JsonParser::JsonParser() {}
 
 QJsonArray JsonParser::extractItemArray(const QByteArray& jsonData, const QString& objectName) {
@@ -42,8 +75,10 @@ QJsonArray JsonParser::extractItemArray(const QByteArray& jsonData, const QStrin
 QHash<int, QVariant> JsonParser::jsonObjectToItemValues(const QJsonObject& itemJsonObject) {
   QHash<int, QVariant> values;
 
-  for (auto iter = ROLE_NAMES.cbegin(), end = ROLE_NAMES.cend(); iter != end; ++iter) {
-    std::pair<int, QVariant> keyValuePair = getKeyValuePair(itemJsonObject, iter.key());
+  QListIterator<UserRoles> i(USER_FACING_ROLES);
+  while (i.hasNext()) {
+    const UserRoles role                  = i.next();
+    std::pair<int, QVariant> keyValuePair = getKeyValuePair(itemJsonObject, role);
     values.insert(keyValuePair.first, keyValuePair.second);
   }
   return values;

formats/jsonparser.h

@@ -14,6 +14,8 @@ class JsonParser {
  public:
   static QList<QHash<int, QVariant>> toItemValuesList(const QByteArray& jsonData,
                                                       const QString& objectName = "");
+  static QByteArray itemValuesListToJson(const QList<QHash<int, QVariant>>& itemValuesList,
+                                         const QString& objectName = "");
 
  private:
   explicit JsonParser();